Re: [PATCH] Small fix for misc/sys/syslog.h

[GOTO Masanori <gotom at debian dot or dot jp>]

At Mon, 14 Feb 2005 16:49:17 -0800,
Ulrich Drepper wrote:
> GOTO Masanori wrote:
> > Including syslog.h
> > warns "discarding qualifiers" with gcc -Wwrite-strings option (I
> > confirmed with gcc 2.95).
> 
> The opposite is equally true.  If this is about removing one type of
> warning the change is not useful since it simply substitutes it for
> other warnings.
>
> I do not question that this is the sane form for the struct, it's just
> too late.

Exactly it's removing one type of warning.  I also agree it's sane
struct.  But I don't think changing char -> const char is "too late"
stuff from the maintenance point of view.

Does your opposite consider only gcc warnings?  In other words, I have
another point: small cleaning up for non-important definitions makes
sense even if it's not useful for most users.  I would like to know
this question for my future modification because I'm getting this kind
of trivial requests.

Thanks in advance,
-- gotom