This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [regex] Remove dead code
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Mon, 08 Nov 2004 08:06:40 -0800
- Subject: Re: [regex] Remove dead code
- Organization: Red Hat, Inc.
- References: <BDAE8226.3DD%paolo.bonzini@lu.unisi.ch>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Paolo Bonzini wrote:
> This patch removes several unused parameters and struct fields.
The patch does not apply correctly. Once I fix it by hand it does not
compile. When I leave out
@@ -602,7 +600,7 @@ re_search_internal (preg, string, length
re_dfa_t *dfa = (re_dfa_t *)preg->buffer;
int left_lim, right_lim, incr;
int fl_longest_match, match_first, match_kind, match_last = -1;
- - int fast_translate, sb, ch;
+ int sb, ch;
#if defined _LIBC || (defined __STDC_VERSION__ && __STDC_VERSION__ >=
199901L)
re_match_context_t mctx = { .dfa = dfa };
#else
it compiles and seems to work. So, beside this hunk the changes look
OK. I applied the patch. The ChangeLog was not correct either. No
directory name, and the second file changed was regexec.c. Please pay
more attention.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFBj5mQ2ijCOnn/RHQRAq5NAJ9hq142o1EsisZADPPrPS/qV8EerQCfR9bk
meddClJBl83yu8BqXKsFCEs=
=aBrP
-----END PGP SIGNATURE-----