This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: PATCH: Don't include <asm/fpu.h> and <asm/elf.h>
On Wed, Oct 08, 2003 at 04:28:00PM +0200, Jakub Jelinek wrote:
> On Wed, Oct 08, 2003 at 09:20:24AM -0700, H. J. Lu wrote:
> > This patch removes the dependencies on <asm/fpu.h> and <asm/elf.h>.
> >
> >
> > H.J.
> > ---
> > 2003-10-08 H.J. Lu <hongjiu.lu@intel.com>
> >
> > * sysdeps/unix/sysv/linux/ia64/bits/sigcontext.h: Don't include
> > <asm/fpu.h>.
> > (struct ia64_fpreg): New.
> >
> > * sysdeps/unix/sysv/linux/ia64/sys/procfs.h: Don't include
> > <asm/elf.h>.
> > (ELF_NGREG): New.
> > (ELF_NFPREG): Likewise.
> > (elf_greg_t): Likewise.
> > (elf_gregset_t): Likewise.
> > (elf_fpreg_t): Likewise.
> > (elf_fpregset_t): Likewise.
> >
> > --- sysdeps/unix/sysv/linux/ia64/bits/sigcontext.h.fpu 2003-07-31 23:31:36.000000000 -0700
> > +++ sysdeps/unix/sysv/linux/ia64/bits/sigcontext.h 2003-10-08 09:18:35.000000000 -0700
> > @@ -1,4 +1,4 @@
> > -/* Copyright (C) 1996, 1997, 1998, 2000, 2001 Free Software Foundation, Inc.
> > +/* Copyright (C) 1996, 1997, 1998, 2000, 2001, 2003 Free Software Foundation, Inc.
> > This file is part of the GNU C Library.
> > Contributed by Jes Sorensen <jes@linuxcare.com>, July 2000
> >
> > @@ -24,9 +24,16 @@
> > #ifndef _BITS_SIGCONTEXT_H
> > #define _BITS_SIGCONTEXT_H 1
> >
> > -#include <asm/fpu.h>
> > #include <bits/sigstack.h>
> >
> > +struct ia64_fpreg
>
> <bits/sigcontext.h> is included by <sys/ucontext.h> which is included by
> <ucontext.h>.
> Isn't struct ia64_fpreg etc. violating namespace?
>
struct ia64_fpreg has to be available in bits/sigcontext.h since it
uses struct ia64_fpreg. I am not sure what choices we have.
H.J.