This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] More regex fixes and testcases


On Mon, Oct 06, 2003 at 02:12:28PM +0200, Paolo Bonzini wrote:
> @@ -71,14 +76,14 @@ main (void)
>  	{
>  	  char buf[500];
>  	  regerror (n, &re, buf, sizeof (buf));
> -	  printf ("regcomp %zd failed: %s\n", i, buf);
> +	  printf ("%s: regcomp %zd failed: %s\n", tests[i].pattern, buf, i);

This looks wrong.  You're passing a char * to %zd format and size_t to %s
format.  Should be something like:
	printf ("\"%s\": regcomp %zd failed: %s\n", tests[i].pattern, i, buf);

> 2003-10-05  Paolo Bonzini  <bonzini@gnu.org>
> 
> 	* libc/posix/bug-regex11.c: add three
> 	failing testcases.

ChangeLog entries shouldn't include libc/ and should start with capital
letter, ie.
	* posix/bug-regex11.c: Add three failing testcases.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]