Re: Problems in new compat NSS module?

[Thorsten Kukuk <kukuk at suse dot de>]

On Sun, Aug 31, Guido Guenther wrote:

> On Fri, Aug 29, 2003 at 08:53:41PM +0200, Thorsten Kukuk wrote:
> > > Check out
> > > <URL:http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=204711> and
> [..snip..] 
> 
> > There is only one hint which could explain the problem of one
> > of the reporter: It seems, getspnam is broken.
> > But this cannot be the reason for the other problems reported
> > in this bug.
> Reverting all changes to nss/ & nis/ to 2003-06-25 fixes the nis login
> problems for several people. So the problem was introduced during that
> date and 2003-07-15.

About nss: This only matters if you use static binaries. Static
binaris, which dlopen NSS modules, only works with the glibc they
are linked against. Everything else is known that it can fail.

nis: This changes where only for nss_compat. nss_compat does not have
any impact on nss_nis or nss_mysql. This is impossible. So the problem
is somehwere else, but it cannot be my change to nss_compat.

About nss_compat: Yes, there is a bug which prevents getspnam from
correct working with shadow over NIS. The fix is trivial:

--- nis/nss_compat/compat-spwd.c
+++ nis/nss_compat/compat-spwd.c        2003/09/01 13:02:09
@@ -435,7 +435,7 @@
   copy_spwd_changes (result, &pwd, p, plen);
   give_spwd_free (&pwd);
   /* We found the entry.  */
-  return NSS_STATUS_RETURN;
+  return NSS_STATUS_SUCCESS;
 }
 
 static enum nss_status
 

For glibc CVS, I will make another patch with some more code
cleanup.

  Thorsten

-- 
Thorsten Kukuk       http://www.suse.de/~kukuk/        kukuk@suse.de
SuSE Linux AG        Deutschherrnstr. 15-19        D-90429 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B