This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mips64 elf64 reloc data structures

Alexandre Oliva <aoliva at redhat dot com> writes:

> On Mar 18, 2003, Roland McGrath <roland at redhat dot com> wrote:
>> I think you should make sure that every place for which these macros
>> matter uses <ldsodefs.h> and do it in mips/ldsodefs.h instead.
> Contrary to my recollections and fears, this seems to have worked.
> I've verified that the ELF64_R_ macros defined in elf/elf.h were not
> used by building glibc for mips64-linux-gnu after adding syntax errors
> to the unwanted definitions, and it still built correctly, so it
> appears that the files that include only elf.h do not need these
> macros.  I'm still concerned that there is a possibility of errors
> being silently introduced by this arrangement, but even my attempt to
> avoid taking risks and adding an explicit include of ldsodefs.h
> everywhere elf.h was included failed: a number of files just can't
> include ldsodefs.h, and I fear some of them may be installed, so I
> gave it up.  I still think some of this code belongs in generic code,
> but I'm leaving it at this for now.  Ok to install?
> Index: ChangeLog
> from  Alexandre Oliva  <aoliva at redhat dot com>
> 	* sysdeps/mips/elf/ldsodefs.h: Add mips-specific elf64 relocation
> 	data structures and macros.  Protect from multiple inclusion.

This is fine, put it in,

 Andreas Jaeger
  SuSE Labs aj at suse dot de
   private aj at arthur dot inka dot de

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]