This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mips64 elf64 reloc data structures

On Mar 14, 2003, Roland McGrath <roland at redhat dot com> wrote:

> Please fix the formatting, to begin with.

Anything other than misplacement of `{'s and long lines?

> Does a standard or another system use these Elf64_Mips_* names?

BFD defines Elf64_Mips_Rel and Elf64_Mips_Rela, but to different
structures.  I don't know whether anyone defines these types, but the
unions and sub-structs, I came up with myself.

> The struct and union without typedef names do not match the naming
> conventions used for the rest of elf.h.

Sorry, I don't see a naming convention I'm supposed to follow.
Ideally, the sub-struct and union names shouldn't be part of the API,
so they should have internal names.  I thought not defining the
typedefs would at least help in this regard.

> As to the include/elf.h hack, for which glibc sources do you need these
> different macro definitions in effect?

Anything that uses ELF_R_TYPE needs the mips elf64-specific version of
the macro to work on little-endian.  That's a lot of code in elf/, as
well as sysdeps/mips/dl-machine.h.

Alexandre Oliva   Enjoy Guarana', see
Red Hat GCC Developer                 aoliva at {redhat dot com,}
CS PhD student at IC-Unicamp        oliva at {lsd dot ic dot unicamp dot br,}
Free Software Evangelist                Professional serial bug killer

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]