This is the mail archive of the
mailing list for the glibc project.
[PATCH] configure.in tweaks for autoconf-2.5X
- From: Art Haas <ahaas at neosoft dot com>
- To: libc-alpha at sources dot redhat dot com
- Date: Fri, 18 Oct 2002 11:54:03 -0500
- Subject: [PATCH] configure.in tweaks for autoconf-2.5X
It's nice to see that glibc has moved to using the newer autoconf.
Here's a small patch that modifies the very top of the configure.in
template to use the autoconf-2.5X AC_INIT format. In switching from
the old style, the AC_CONFIG_SRCDIR macro is added to provide the file
existance test done in the old AC_INIT format. Also, the
AC_CONFIG_HEADER macro is now listed as AC_CONFIG_HEADERS, so I added
the extra "S", as well as the explicit quotes in the macro argument.
It is probably good to move AC_INIT as the first macro in the template
as well, as is done in this patch. The docs say that AC_PREREQ
can come before AC_INIT, and AC_REVISION just puts a version string in
the configure script, so I don't see a problem where it is now, but
moving AC_INIT to be the first macro seems more in agreement with the
autoconf docs, so I moved it up two lines.
There are a number of other cleanups to the configure template that can
be done now that autoconf-2.5X is required. The AC_OUTPUT macro should
be split into AC_CONFIG_FILES and then call AC_OUTPUT, for example.
There are other possible additions that can be done, such as using
AC_HELP_STRING macros in the AC_ARG_ENABLE and AC_ARG_WITH macros. I'm
planning on sending a few patches to do these sort of things, so expect
a couple of patches in the next few days that do these sorts of things.
Also, it might be good to rename "configure.in" to "configure.ac", as
the ".ac" extension is more in the autoconf-2.5X mode.
Here's the patch - I've regenerated my configure script, and configured
a build without a problem.
RCS file: /cvs/glibc/libc/configure.in,v
retrieving revision 1.364
diff -u -r1.364 configure.in
--- configure.in 17 Oct 2002 23:47:26 -0000 1.364
+++ configure.in 18 Oct 2002 16:50:20 -0000
@@ -1,8 +1,9 @@
dnl Process this file with autoconf to produce a configure script.
+AC_INIT([GNU Libc], [2.3.1], [http://sources.redhat.com/glibc], [glibc])
AC_PREREQ(2.53)dnl dnl Minimum Autoconf version required.
# This will get text that should go into config.make.
They that can give up essential liberty to obtain a little temporary safety
deserve neither liberty nor safety.
-- Benjamin Franklin, Historical Review of Pennsylvania, 1759