This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] add ppc64 specific code
- From: "Steve Munroe" <sjmunroe at us dot ibm dot com>
- To: Roland McGrath <roland at redhat dot com>, Geoff Keating <geoffk at redhat dot com>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Tue, 17 Sep 2002 13:10:44 -0500
- Subject: Re: [PATCH] add ppc64 specific code
Roland McGrath wrote:
> The function dl_reloc_overflow needs to be named _dl_reloc_overflow
> instead. Rather than using asm's with .hidden, you should just use
> attribute_hidden on the extern decl in dl-machine.h.
OK.
Actually this was copied from powerpc32, which still uses the
dl_reloc_overflow symbol dl-machine.c, but that is OK because it is static?
A related question: Many of the powerpc64 files where copied from powerpc
(and other places) so I have kept the full
copyright history and added 2002. However I notice the some of these files,
when checked in, have only the 2002 date.
So the policy is not clear to me. Technically these are "new files" but
many are based on previous work (always within glibc).
So in the case of copying files into new directory (while slight
modifications), when should I include whole copywrite pedigree and when
should I just specify the release year?