This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] improve regex performance


Isamu Hasegawa <isamu@yamato.ibm.com> writes:

> This is an interim report since it seems that there are still problems.

Well, yeah, there are still problems.  But I don't see the problem you
see.  In fact, the test cases I had work fine now.  And the time
needed is much better (only between 2000% and 8000% slower :-).

The problems you might have experienced could be mine.  I had to fix
several bugs in the tst-regex program.  I've checked in a fixed
version now.  This version passes with your patches applied.  Only the
one test commented out with DOES_NOT_WORK doesn't work.  It also fails
for the single-byte case which is worrisome.


If you don't see any problems with your patch I'd like to check it in.
Please provide a ChangeLog entries.  In addition I'd like to ask you
to look at the one failing test.

Thanks,

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]