[PATCH 1/2] [abidiff] Fix spurious new lines after diff sections.

Dodji Seketeli dodji@seketeli.org
Thu Mar 12 13:03:08 GMT 2020


Hello Giuliano,

Giuliano Procida <gprocida@google.com> a écrit:

> The top-level corpus diff routines in abidiff have varied ways of
> tracking whether or not to emit a new line after each section. Reuse
> of state variables (which aren't always cleared) between sections
> means that spurious new lines are sometimes output.
>
> This patch replaces this new line logic in the functions with the same
> simple pattern of using a local boolean state variable.
>
> 	* src/abg-default-reporter.cc (report): In the corpus_diff
> 	overload, just use a local boolean emitted state variable
> 	within each section to determine whether or not to follow the
> 	section with an extra new line.
> 	* src/abg-leaf-reporter.cc: Ditto.
> 	* tests/data/test-*/*report*.txt: Remove unwanted new lines
> 	from 27 files.

This looks good to me and I have applied to master.

Thanks!

-- 
		Dodji


More information about the Libabigail mailing list