[PATCH v2] abidiff/kmidiff: do not default-suppress added symbols

[Dodji Seketeli]

Hello Matthias,

Matthias Maennich <maennich@google.com> a écrit:

> kmidiff and abidiff do filter out added symbols (vars, functions and
> symbols without debug info) by default when dealing with kernel
> binaries. The reason for this is that the ABI could be considered
> compatible and not broken when adding symbols. In practice, this is
> confusing as there is no possibility for a symmetric comparison (i.e. a
> deleted function when comparing left to right is an added function when
> comparing right to left). Furthermore, there is no option available to
> actually report these added symbols. I thought of adding an option to
> report added symbols, but in the end came to the conclusion that we
> should behave consistent across the various ways you can diff an ABI
> with abidiff and kmidiff and should not change default behaviour for a
> particular type of binary. Hence, remove the default behaviour of
> filtering out added symbols when comparing kernel binaries. To restore
> the current behaviour, the user needs to parametrize with the tools with
> --no-added-syms --no-unreferenced-symbols.
>
> Adjusted test cases accordingly and add a new test that covers the old
> behaviour new available with additional flags to abidiff.
>
> 	* tools/abidiff.cc (adjust_diff_context_for_kmidiff): Drop
> 	default suppression of added symbols.
> 	* tools/kmidiff.cc (set_diff_context): Likewise.
> 	* tests/data/test-diff-suppr/test46-PR25128-report-1.txt: Adjust
> 	test expectation.
> 	* tests/data/test-diff-suppr/test46-PR25128-report-2.txt: Add
> 	test case for abidiff with flag --no-added-syms.
> 	* tests/data/Makefile.am: add new testcase.

This is OK for master, thanks!

Cheers,

-- 
		Dodji