Re: [Bug default/25128] abidiff is incorrectly comparing the size for declaration-only types with --leaf-changes-only

[Dodji Seketeli <dodji@seketeli.org>]

"maennich at android dot com" <sourceware-bugzilla@sourceware.org> a
écrit:

> https://sourceware.org/bugzilla/show_bug.cgi?id=25128
>
> --- Comment #2 from Matthias Maennich <maennich at android dot com> ---
> Created attachment 12052
>   --> https://sourceware.org/bugzilla/attachment.cgi?id=12052&action=edit
> another reproducer
>
> I found another case. This time the default reporter recognizes the difference.
> The leaf reporter does not report a difference, but returns rc=4 indicating an
> ABI difference.
>
>
> $ abidiff base.xml new.xml    # i.e. the default reporter
>
> Functions changes summary: 0 Removed, 1 Changed (710 filtered out), 0 Added functions

[...]


>   [C]'function sk_buff* __cfg80211_alloc_event_skb(wiphy*, wireless_dev*,
> nl80211_commands, nl80211_attrs, unsigned int, int, int, gfp_t)' at
> nl80211.c:9646:1 has some indirect sub-type changes:
>     parameter 2 of type 'wireless_dev*' has sub-type changes:

[...]


>                                                array element type
> 'xfrm_policy*' changed:
>                                                  in pointed to type 'struct
> xfrm_policy':
>                                                    type size changed from 6336
> to 0 (in bits)

Right.  I could reproduce this with the input you attached here, thank
you for that.

I have added the patch https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=37db0479b72e819ea0f2967d
to the existing PR25095 branch.  That should hopefully address the issue
you are seeing.

Sorry for the inconvenience.

-- 
		Dodji