[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug default/25095] abidiff does not correctly respect --kmi-whitelist



https://sourceware.org/bugzilla/show_bug.cgi?id=25095

--- Comment #4 from Matthias Maennich <maennich at android dot com> ---
Created attachment 12049
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12049&action=edit
another reproducer

Whitelisting seems to affect the leaf-changes-only analysis:

Consider in the attachment

abi.xml    - generated with abidw from a kernel tree
abi-wl.xml - as above, but with -kmi-whitelist whitelist
whitelist  - the whitelist

$ abidiff abi.xml abi-wl.xml --kmi-whitelist whitelist --impacted-interfaces
--leaf-changes-only

Changes are now reported as they impact a symbol on the whitelist:


Leaf changes summary: 23 artifacts changed (2 filtered out)
Changed leaf types summary: 23 (2 filtered out) leaf types changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 0 Added function
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added variable

'struct anon_vma' changed:
  type size changed from 640 to 0 (in bits)

  one impacted interface:
    function int PageMovable(page*)


'struct audit_context' changed:
  type size changed from 7680 to 0 (in bits)

  one impacted interface:
    function int PageMovable(page*)


'struct cfs_rq' changed:
  type size changed from 3072 to 0 (in bits)

  one impacted interface:
    function int PageMovable(page*)


[...]


Is that expected behaviour or do we have to skip these declaration-only symbols
in this case?

-- 
You are receiving this mail because:
You are on the CC list for the bug.