[Bug default/24690] New: Undetected ABI break in the Flatpak library

["bochecha at daitauha dot fr" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=24690

            Bug ID: 24690
           Summary: Undetected ABI break in the Flatpak library
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: bochecha at daitauha dot fr
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Flatpak inadvertently broke its ABI between the 1.2 branch and the 1.4.0
release. This was not expected and was fixed with a quick 1.4.1 release.

I'm not sure of the change that broke the ABI (too many to go through), but
here is the patch with the fix:

https://github.com/flatpak/flatpak/commit/8b42f89e7a3c4391f4937ff983fee89bef127e2d

Flatpak doesn't use libabigail (or anything else) to ensure it doesn't break
ABI, which is probably something to look into at some point. But that's not the
purpose of this bug report. ;)

In any case, libabigail didn't find the ABI break, which could have prevented
it at least:

https://taskotron.fedoraproject.org/artifacts/all/0a799e96-814e-11e9-82c3-52540077ca13/tests.yml/flatpak-1.4.0-1.fc30.log

That seems like something libabigail should be able to detect.

-- 
You are receiving this mail because:
You are on the CC list for the bug.