[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 00/11] Refactor abg-writer

Hi Dodji!

On Wed, May 22, 2019 at 02:32:12PM +0200, Dodji Seketeli wrote:
> Hello Matthias,
> 
> 
> Thank you for this patch series!
> 
> It looks good to me so I have applied it to master.
> 
> I have however picked a few nits here and there and applied some very
> slightly modified versions of the patches.
> 
> Please find below the detail of my comments.
> 

Thanks for applying it right away with all the useful additions!

[...]

> I have also mentioned the names of the changed functions in the
> ChangeLog, following the (GNU) conventions referred to int he
> COMMIT-LOG-GUIDLINES file at
> https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=blob;f=COMMIT-LOG-GUIDELINES.
> 

Especially thanks for cleaning up the ChangeLogs. I tried to follow the rules,
but I guess I need to read that part again more carefully. :-)

I also saw you accepting the 'breaking' change that drops compatibility with
previous libabigail versions. I assume, the next version will have to bump the
major version then. Speaking of which, what would be the criteria for releasing
current master as a new version?

-- 
Cheers,
Matthias