[PATCH v1 00/10] Fix warnings emitted when building with Clang

["Matthias Maennich via libabigail" <libabigail@sourceware.org>]

Hi!

While exploring the code base I was using clang-7 to compile. This patch series
addresses warnings that were emitted when doing so. I split them up in single
commits (grouped by type) as some might be subject to discussion.

One warning category (-Woverloaded-virtual) is still outstanding. That might
require more work / refactoring to solve.

Cheers,
Matthias

===

Matthias Maennich (10):
  abg-fwd.h: fix mismatched tags for ir_node_visitor
  abilint: fix return types bool -> int
  abg-reader: clarify boolean use of assignment
  diff-utils: point: fix postfix decrement/increment operator
  add missing virtual destructors
  viz-dot: remove unused members from dot
  suppressions: drop unused parameter from type_is_suppressed
  ir: drop unused data members from {environment,qualified_name}_setter
  distinct_diff: avoid expression with side effects within typeid
  dwarf-reader: fix recursion in expr_result::operator&

 include/abg-comparison.h   |  4 ++++
 include/abg-corpus.h       |  2 ++
 include/abg-diff-utils.h   |  4 ++--
 include/abg-fwd.h          |  2 +-
 include/abg-reporter.h     |  1 +
 include/abg-traverse.h     |  3 +++
 include/abg-viz-dot.h      |  8 ++------
 src/abg-comparison.cc      |  3 ++-
 src/abg-dwarf-reader.cc    |  2 +-
 src/abg-ir.cc              | 16 ++++------------
 src/abg-reader.cc          |  2 +-
 src/abg-suppression-priv.h |  3 +--
 tests/print-diff-tree.cc   |  2 +-
 tools/abilint.cc           | 24 ++++++++++++------------
 14 files changed, 37 insertions(+), 39 deletions(-)

-- 
2.21.0.392.gf8f6787159e-goog