[Bug default/21566] fedabipkgdiff tool returns "max() arg is an empty sequence" error message in some cases

["sinny at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=21566

--- Comment #4 from Sinny Kumari <sinny at redhat dot com> ---
(In reply to dodji from comment #3)
> Hey Sinny,
> 
> Thanks for the patch!
> 
> I have some comments below.

Thanks for reviewing it.

> 
> >  @log_call
> > @@ -1111,7 +1111,9 @@ def diff_local_rpm_with_latest_rpm_from_koji():
> >          delete_download_cache()
> >  
> >      download_rpms(rpm_col1.rpms_iter())
> > -    result = run_abipkgdiff(rpm_col1, rpm_col2)
> > +    result = 0
> > +    if rpm_col1.rpms and rpm_col2.rpms:
> > +        result = run_abipkgdiff(rpm_col1, rpm_col2)
> 
> Why this change here?  shouldn't run_abipkgdiff just return zero if
> either rpm_col1 or rpm_col2 is empty, thanks to your previous diff hunk
> above?
> 
> If this change is not necessary, then I'd rather just drop it, as it
> just clutters the code otherwise.

It's not necessary. I added it to avoid calling un-necessarly abipkgdiff when
not needed. Thought of it as a better coding practice :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.