Re: [Feature] Add --self-compare option in fedabipkgdiff

[Dodji Seketeli <dodji@seketeli.org>]

Chenxiong Qi <cqi@redhat.com> a écrit:

> On Sun, May 21, 2017 at 6:29 PM, Sinny Kumari <ksinny@gmail.com> wrote:
>> Hi,
>>
>> This patch (available in email attachment)  adds --self-compare option
>> in fedabipkgdiff tool.
>>
>> fedabipkgdiff tool can communicate with Fedora koji and has capability
>> to download and perform ABI comparison between specified NVRs.
>>
>> With addition of --self-compare option, it will be possible to perform
>> ABI comparison on same package. One of the important usecase of this
>> option is to run automated ABI checks on packages with known expected
>> result i.e. no ABI change. This usecase will be useful to ensure that
>> libabigail functionality doesn't break with new commits made.
>> This option can be invoked as:
>>   fedabipkgdiff -a --self-compare -fc24 pacakge_name
>
> Typo here.
>
> LGTM.

For what it's worth, I agree fully with Chenxiong here.  It looks good
to me with the typo above fixed.

Thanks!

Cheers,

-- 
		Dodji