Re: [PATCH 4/4] fedabipkgdiff refuses to compare packages with the same

[Dodji Seketeli <dodji@redhat.com>]

Gentle ping for a review of this patch.

Dodji Seketeli <dodji@redhat.com> a écrit:

> Hello Chenxiong,
>
> I tried to run:
>
>     fedabipkgdiff vte291-0.39.1-1.fc22.x86_64 vte291-0.39.90-1.fc22.x86_64
>
> And it wouldn't work :-(
>
> The program considers the two packages as not being "peers".  This has
> to do with the RPM.is_peer method which considers the two package as
> not being "peers", just because they have the same release number
> (1.fc22).
>
> They should be considered peers, though, because they have the same
> name but different {version, release} pairs.
>
> This patch fixes the RPM.is_peer method and adds the aforementioned
> packages to the regression test suite for good measure.
>
> Below is the ChangeLog of the file.
>
> I am attaching the patch itself, compressed with gzip, as it's a little
> bit big due to the fact that it adds some RPMs to the regression test
> suite.
>
> 	* tools/fedabipkgdiff (RPM.is_peer): Update comment.  Fix logic.
> 	* tests/data/test-fedabipkgdiff/packages/vte291/0.39.1/1.fc22/x86_64/vte291-0.39.1-1.fc22.x86_64.rpm:
> 	New test input file.
> 	* tests/data/test-fedabipkgdiff/packages/vte291/0.39.1/1.fc22/x86_64/vte291-debuginfo-0.39.1-1.fc22.x86_64.rpm: Likewise.
> 	* tests/data/test-fedabipkgdiff/packages/vte291/0.39.1/1.fc22/x86_64/vte291-devel-0.39.1-1.fc22.x86_64.rpm: Likewise.
> 	* tests/data/test-fedabipkgdiff/packages/vte291/0.39.90/1.fc22/x86_64/vte291-0.39.90-1.fc22.x86_64.rpm: Likewise.
> 	* tests/data/test-fedabipkgdiff/packages/vte291/0.39.90/1.fc22/x86_64/vte291-debuginfo-0.39.90-1.fc22.x86_64.rpm: Likewise.
> 	* tests/data/test-fedabipkgdiff/packages/vte291/0.39.90/1.fc22/x86_64/vte291-devel-0.39.90-1.fc22.x86_64.rpm: Likewise.
> 	* tests/data/Makefile.am: Add the new test input data to source
> 	distribution.
> 	* tests/mockfedabipkgdiff.in: Update the package and build
> 	information to add the new vte291-0.39.1-1.fc22.x86_64.rpm and
> 	vte291-0.39.90-1.fc22.x86_64.rpm packages (as well as their devel
> 	and debuginfo packages) into the "mock" Koji build database.
> 	* tests/runtestfedabipkgdiff.py.in:  Make this test harness run
> 	over the two aforementioned packages.
>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>

-- 
		Dodji