[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Bug 18754 - Add a --no-added-symbols option to abidiff
Hello Ondrej,
Ondrej Oprala <ondrej.oprala@gmail.com> a écrit:
> With this option, abidiff is now able to filter out added
> symbols just like abipkgdiff is.
Thanks for the patch. I have pushed it to master. \o/
I amended it somewhat to fix some nits.
First, the new --no-added-syms option lacks documentation in the manual,
in the doc/manuals/abidiff.rst file. I have added it.
> * tools/abidiff.cc (struct options): Add show_added_syms and
> set it to true by default.
> (display_usage): Document the new options --no-added-syms. If
> this is the only suppression option specified, it is equivalent
> to specifying --show_{changed,deleted}_{fns,vars} as arguments
> to abidiff. If any of those options are specified before
> --no-added-syms, then it has no effect.
> (main): Parse the new option and set show_added_{fns,vars,syms}
> and show_all_{fns,vars} to false if --no-added-syms is
> specified.
This parsing is done in the function parse_command_line, not in main. I
have fixed that.
[...]
> + if (!(opts.show_changed_fns || opts.show_changed_vars ||
> + opts.show_deleted_fns || opts.show_deleted_vars))
> + {
I changed the indentation here to make it be one || clause per line, as
is done elsewhere in the code.
Thanks for the patch! It's appreciated!
Cheers,
--
Dodji