[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug default/20199] consider integral type synonyms as being equal



https://sourceware.org/bugzilla/show_bug.cgi?id=20199

--- Comment #7 from dodji at redhat dot com ---
(In reply to Ben Woodard from comment #6)
> but remember to also take care of:
> 
> type name changed from '_Bool' to 'unsigned char'

This is a different problem.

_Bool and unsigned char are different built-in types.  _Bool appeared in C11
(http://en.cppreference.com/w/c/types/boolean).  So I think they ought to
compare different.

Whereas 'unsigned short' and "short unsigned int" are exactly the same type,
and so should compare equal, even if the strings representing their names are
different.

In my opinion the '_Bool' to 'unsigned char' change is potentially a real
problem, at least from an API point of view.  So I think it's useful that
abidiff tells users about it.  If, in a particular context of a particular
project users (after carefully reviewing all the reported instances of changes
from _Bool to unsigned char) decide that they want the tool to suppress those
change reports, then I think they should use a suppression specification
instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.