[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add fedabipkgdiff bash completion to dist



On 06/30/2016 10:04 PM, Dodji Seketeli wrote:

Hello Chenxiong,

Chenxiong Qi <cqi@redhat.com> a Ãcrit:


fedabipkgdiff bash completion added previously is not included in the
final distribution tarball. This is fixed. And, mode of file
bash_completion/fedabipkgdiff is changed to 775. I'm not sure whether
this change is necessary, I'm just aware of the mode is 775 from other
bash completion files, just keep the same as others.


OK.


Subject: [PATCH] add fedabipkgdiff bash completion to dist


Please, in the future, could you make sure to start the title of the
patch with a capital letter? like "Add" here, and not "add".


	* bash-completion/Makefile.am: add fedabipkgdiff


Same with the sentences in the ChangeLog.  It's "Add", rather than
"add".


	* bash-completion/fedabipkgdiff: change mode to 775


Same here, it's "Change", not "change".

Up until now, I have always made the change at commit time, but I don't
remember if I forgot to tell you or not :-)

I did the change this time again and committed the patch to master.

Thanks!
Oh, sorry for this. Thanks for pointing out this and correcting this time. BTW, is there any out-of-box mode or command in Emacs to help checking such errors? 

--
Regards,
Chenxiong Qi