[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug default/19081] Make abipkgdiff be multi-threaded



https://sourceware.org/bugzilla/show_bug.cgi?id=19081

--- Comment #5 from Ondrej Oprala <ooprala at redhat dot com> ---
So here's my take on this issue.
I've been using the rpms of vtk to test this throughout.
Prior to any threading attempts, running this:
abipkgdiff vtk-6.1.0-26.fc23.x86_64.rpm vtk-6.2.0-8.fc23.x86_64.rpm --d1 
vtk-debuginfo-6.1.0-26.fc23.x86_64.rpm --d2 
vtk-debuginfo-6.2.0-8.fc23.x86_64.rpm

took a bit less than 4 mins:
230,08s user 6,60s system 101% cpu 3:53,03 total

threads make the numbers much nicer \o/
381,17s user 14,15s system 492% cpu 1:20,23 total

I tried to be as verbose as possible with the commit message, but if you 
think I missed
anything anywhere, please tell me, I want this to be as good as it can get.

Helgrind only complains about elf_version (and elf_begin), which we 
already discussed on the IRC.
Didn't try testing it with anything really huge yet like Ben's libgcj etc...
Any and all comments would be very appreciated.

On 07.10.2015 11:34, dodji at redhat dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=19081
>
>              Bug ID: 19081
>             Summary: Make abipkgdiff be multi-threaded
>             Product: libabigail
>             Version: unspecified
>              Status: NEW
>            Severity: enhancement
>            Priority: P2
>           Component: default
>            Assignee: dodji at redhat dot com
>            Reporter: dodji at redhat dot com
>                  CC: libabigail at sourceware dot org
>    Target Milestone: ---
>
> abipkgdiff can use pthreads to run comparison on pairs of libraries (each pair
> contains two versions of the same library) carried by two packages, just like
> what test-read-dwarf.cc does already.
>
> That could potentially greatly speed up abipkgdiff, depending on the number of
> physical cores the system has.
>

-- 
You are receiving this mail because:
You are on the CC list for the bug.