This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: [rfa] missing frame_register
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: David Carlton <carlton at math dot stanford dot edu>
- Cc: insight at sources dot redhat dot com
- Date: Mon, 17 Mar 2003 16:09:45 -0500
- Subject: Re: [rfa] missing frame_register
- References: <ro11y15g4he.fsf@jackfruit.Stanford.EDU>
There's a remaining use of get_saved_register in
gdbtk/generic/gdbtk-register.c. This patch attempts to convert it
over, but I might have gotten it wrong: I just copied some similar
conversions from Andrew's earlier patch. All I've done is verified
that this patch allows the file in question to compile; I don't use
gdbtk or run the gdbtk tests, so I don't have any way of checking
whether or not it works.
[changed to insight at ]
Andrew, is this OK? I assume it's either obviously okay to commit or
obviously wrong.
You'll also need to pass in a scratch `addr' and `lval'. After that, it
should be ok.
Andrew
David Carlton
carlton at math dot stanford dot edu
2003-03-17 David Carlton <carlton at math dot stanford dot edu>
* generic/gdbtk-register.c (get_register): Replace use of
get_saved_register by frame_register.
Index: gdbtk-register.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v
retrieving revision 1.15
diff -u -p -r1.15 gdbtk-register.c
--- gdbtk-register.c 12 Feb 2003 00:39:46 -0000 1.15
+++ gdbtk-register.c 17 Mar 2003 19:43:25 -0000
@@ -287,8 +287,11 @@ get_register (int regnum, void *arg)
return;
}
- get_saved_register (raw_buffer, &optim, (CORE_ADDR *) NULL, deprecated_selected_frame,
- regnum, (enum lval_type *) NULL);
+ {
+ int realnum;
+ frame_register (deprecated_selected_frame, regnum, &optim,
+ NULL, NULL, &realnum, raw_buffer);
+ }
if (optim)
{
Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr,