This is the mail archive of the guile@sourceware.cygnus.com mailing list for the Guile project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: typedef void *


gjb@cs.washington.edu writes:
> > ramap.c is entirely incomprehensible to me. The function raeql is
> > schizophrenic: it can return SCM_BOOLs, 0 as well as what comes out
> > ramapc().
> 
> Looks like a mess to me, too.  I think scm_raequal is supposed to

It starts with the name. Whoever came up with ramap for what should be
called arraymap?

> When in doubt, do what you think is right.  Add a HWN:FIXME:: comment
> when you're not certain it's the right thing, or there's an issue you
> want someone to look at later.

Ok, I made some more fixes to ramap.c. 

> > 	     #define JBACTIVE(O) (SCM_CARW (O) & (1L << 16L))
> > 
> > As far as I can tell, this would cause a core dump (referencing the
> > nilpointer)
> 
> The O, above, is a letter "O", not a zero.  Those macro formal argument
> names should *absolutely* be changed.  Whoever used O was just playing
> an evil mind game, I suspect.  I'd change all the Os to OBJ or S or
> something.

Yep. Done. Patch in usual place.

-- 

Han-Wen Nienhuys, hanwen@cs.uu.nl ** GNU LilyPond - The Music Typesetter 
      http://www.cs.uu.nl/people/hanwen/lilypond/index.html 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]