This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.26.9000-988-g95511aa
- From: jsm28 at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 15 Dec 2017 22:37:39 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.26.9000-988-g95511aa
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 95511aab9d5202470b90530e83d18a6f4b4aeb6b (commit)
from a7e3edf4f252fb72afeb8ecca946a2d8294bb577 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=95511aab9d5202470b90530e83d18a6f4b4aeb6b
commit 95511aab9d5202470b90530e83d18a6f4b4aeb6b
Author: Joseph Myers <joseph@codesourcery.com>
Date: Fri Dec 15 22:37:17 2017 +0000
Fix testing with read-only source directory.
Three tests fail with a read-only source directory because they try to
write into the source directory. None of these write into it in a way
that should actually be problematic for concurrent builds sharing the
same writable source directory, but avoiding any writing into the
source directory (from testing, or from building glibc if the source
timestamps are properly ordered) is still a good idea, as being able
to build with read-only sources helps make sure there isn't anything
that could cause problems for concurrent builds.
This patch changes the tests in question to use either /tmp or the
build directory to write their temporary files (or to test O_TMPFILE,
as applicable).
Tested for x86_64.
* io/Makefile (tst-open-tmpfile-ARGS): New variable.
* posix/tst-mmap-offset.c (fname): Use /tmp.
* stdlib/tst-setcontext3.sh (tempfile): Use ${objpfx}.
diff --git a/ChangeLog b/ChangeLog
index e96b2b4..852043e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2017-12-15 Joseph Myers <joseph@codesourcery.com>
+
+ * io/Makefile (tst-open-tmpfile-ARGS): New variable.
+ * posix/tst-mmap-offset.c (fname): Use /tmp.
+ * stdlib/tst-setcontext3.sh (tempfile): Use ${objpfx}.
+
2017-12-15 Steve Ellcey <sellcey@cavium.com>
* nscd/dbg_log.c (dbg_log): Increase msg buffer size.
diff --git a/io/Makefile b/io/Makefile
index b3ee5ae..c725195 100644
--- a/io/Makefile
+++ b/io/Makefile
@@ -109,6 +109,8 @@ test-stat2-ARGS = Makefile . $(objpfx)test-stat2
tst-statvfs-ARGS = $(objpfx)tst-statvfs tst-statvfs.c /tmp
+tst-open-tmpfile-ARGS = --test-dir=$(objpfx)
+
ifeq ($(run-built-tests),yes)
$(objpfx)ftwtest.out: ftwtest-sh $(objpfx)ftwtest
$(SHELL) $< $(common-objpfx) '$(test-program-cmd)' > $@; \
diff --git a/posix/tst-mmap-offset.c b/posix/tst-mmap-offset.c
index 5bb88aa..5e940c8 100644
--- a/posix/tst-mmap-offset.c
+++ b/posix/tst-mmap-offset.c
@@ -29,7 +29,7 @@
static int fd;
static long int page_shift;
-static char fname[] = "tst-mmap-offset-XXXXXX";
+static char fname[] = "/tmp/tst-mmap-offset-XXXXXX";
static void
do_prepare (int argc, char **argv)
diff --git a/stdlib/tst-setcontext3.sh b/stdlib/tst-setcontext3.sh
index 158d0dc..014e7cf 100644
--- a/stdlib/tst-setcontext3.sh
+++ b/stdlib/tst-setcontext3.sh
@@ -34,7 +34,7 @@ cleanup() {
}
trap cleanup 0
-tempfile=$(mktemp "tst-setcontext3.XXXXXXXXXX")
+tempfile=$(mktemp "${objpfx}tst-setcontext3.XXXXXXXXXX")
# We want to run the test program and see if secontext called
# exit() and wrote out the test file we specified. If the
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 6 ++++++
io/Makefile | 2 ++
posix/tst-mmap-offset.c | 2 +-
stdlib/tst-setcontext3.sh | 2 +-
4 files changed, 10 insertions(+), 2 deletions(-)
hooks/post-receive
--
GNU C Library master sources