This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug malloc/25194] malloc.c: do_set_mxfast incorrectly casts the mallopt value to an unsigned


https://sourceware.org/bugzilla/show_bug.cgi?id=25194

--- Comment #5 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Carlos O'Donell from comment #4)
> (In reply to Andreas Schwab from comment #3)
> > There is nothing wrong with the range checking, it's just that the first
> > condition is redundant.
> 
> The original range check was in mallopt to detect a negative mxfast value
> and return 0 as a result (mallopt failure). We no longer do that range
> detection in mallopt, so negative mxfast values don't cause mallopt to fail
> anymore.

Not just negative, but out of range, and return a failure. Now mallopt always
succeeds. This is a change in semantics from the previous code and I didn't
notice it during review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]