[Bug libc/23579] Errors misreported in preadv2

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=23579

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  7a16bdbb9ff4122af0a28dc20996c95352011fdd (commit)
      from  81dca813cc35f91414731fdd0ff6b756d5e1827f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7a16bdbb9ff4122af0a28dc20996c95352011fdd

commit 7a16bdbb9ff4122af0a28dc20996c95352011fdd
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Aug 29 16:36:44 2018 -0300

    Fix misreported errno on preadv2/pwritev2 (BZ#23579)

    The fallback code of Linux wrapper for preadv2/pwritev2 executes
    regardless of the errno code for preadv2, instead of the case where
    the syscall is not supported.

    This fixes it by calling the fallback code iff errno is ENOSYS. The
    patch also adds tests for both invalid file descriptor and invalid
    iov_len and vector count.

    The only discrepancy between preadv2 and fallback code regarding
    error reporting is when an invalid flags are used.  The fallback code
    bails out earlier with ENOTSUP instead of EINVAL/EBADF when the syscall
    is used.

    Checked on x86_64-linux-gnu on a 4.4.0 and 4.15.0 kernel.

        [BZ #23579]
        * misc/tst-preadvwritev2-common.c (do_test_with_invalid_fd): New
        test.
        * misc/tst-preadvwritev2.c, misc/tst-preadvwritev64v2.c (do_test):
        Call do_test_with_invalid_fd.
        * sysdeps/unix/sysv/linux/preadv2.c (preadv2): Use fallback code iff
        errno is ENOSYS.
        * sysdeps/unix/sysv/linux/preadv64v2.c (preadv64v2): Likewise.
        * sysdeps/unix/sysv/linux/pwritev2.c (pwritev2): Likewise.
        * sysdeps/unix/sysv/linux/pwritev64v2.c (pwritev64v2): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                             |   13 +++++++
 misc/tst-preadvwritev2-common.c       |   65 +++++++++++++++++++++++++++++++--
 misc/tst-preadvwritev2.c              |    2 +
 misc/tst-preadvwritev64v2.c           |    2 +
 sysdeps/unix/sysv/linux/preadv2.c     |    2 +-
 sysdeps/unix/sysv/linux/preadv64v2.c  |    2 +-
 sysdeps/unix/sysv/linux/pwritev2.c    |    2 +-
 sysdeps/unix/sysv/linux/pwritev64v2.c |    2 +-
 8 files changed, 83 insertions(+), 7 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.