This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug string/21006] string/tst-xbzero-opt fails on s390x


https://sourceware.org/bugzilla/show_bug.cgi?id=21006

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  570c443352023691f4f7c9ed40199f18c746568c (commit)
      from  b040e1b0842c35ab444e8502db6ae59389d1e3d5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=570c443352023691f4f7c9ed40199f18c746568c

commit 570c443352023691f4f7c9ed40199f18c746568c
Author: Stefan Liebler <stli@linux.vnet.ibm.com>
Date:   Tue Jan 17 08:54:58 2017 +0100

    S390: Fix FAIL in test string/tst-xbzero-opt [BZ #21006]

    On s390x this test failed with:
    FAIL: explicit clear/test: expected 0 got 1

    In setup_explicit_clear, the buffer is filled with the test_pattern.
    On s390x the memcpy in prepare_test_buffer is done by loading
    r4 / r5 with the test_pattern and using store multiple instruction
    to store r4 / r5 to buf.
    If explicit_bzero is resolved in setup_explicit_clear, r4 / r5 is
    stored to stack by _dl_runtime_resolve and the call to memmem in
    count_test_patterns finds a hit of the test_pattern on the stack.

    This patch resolves all symbols at program startup by linking with
    -z now.  This omits the call of _dl_runtime_resolve within
    setup_explicit_clear and the test passes.

    ChangeLog:

        [BZ #21006]
        * string/Makefile (LDFLAGS-tst-xbzero-opt): New variable.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog       |    5 +++++
 string/Makefile |    8 ++++++++
 2 files changed, 13 insertions(+), 0 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]