This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug string/20558] POSIX bcopy/bzero decls do not implement Object Size Checking

--- Comment #6 from cvs-commit at gcc dot <cvs-commit at gcc dot> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  38765ab68f329fd84a5984decc8953f8c89d6e5c (commit)
      from  983a9637f730fa265e228509d090c4c5f031d713 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------;h=38765ab68f329fd84a5984decc8953f8c89d6e5c

commit 38765ab68f329fd84a5984decc8953f8c89d6e5c
Author: Adhemerval Zanella <>
Date:   Thu Jan 5 10:07:24 2017 -0200

    Use fortify macros for b{zero,copy} along decl from strings.h

    As described in BZ#20558, bzero and bcopy declaration can only benefit
    from fortified macros when decl came from string.h and when __USE_MISC
    is defined (default behaviour).

    This is due no standard includes those functions in string.h, so they
    are only declared if __USE_MISC is defined (as pointed out in comment 4).
    However fortification should be orthogona to other features test macros,
    i.e, any function should be fortified if that function is declared.

    To fix this behavior, the patch moved the bzero, bcopy, and
    __explicit_bzero_chk to a common header (string/bits/strings_fortified.h)
    and explicit fortified inclusion macros similar to string.h is added
    on strings.h.  This allows to get fortified declarions by only including

    Checked on x86_64-linux-gnu and along on a bootstrap installation to check
    if the fortified are correctly triggered with example from bug report.

        [BZ #20558]
        * string/bits/string3.h [__USE_MISC] (bcopy): Move to
        [__USE_MISC] (bzero): Likewise.
        [__USE_MISC] (explicit_bzero): Likewise.
        * string/strings.h: Include strings_fortified.h.
        * string/Makefile (headers): Add strings_fortified.h.
        * string/bits/strings_fortified.h: New file.
        * include/bits/strings_fortified.h: Likewise.


Summary of changes:
 ChangeLog                                          |   12 +++++++
 include/bits/strings_fortified.h                   |    1 +
 string/Makefile                                    |    3 +-
 string/bits/string3.h                              |   21 +-----------
 .../bits/strings_fortified.h                       |   35 +++++++++----------
 string/strings.h                                   |    8 ++++
 6 files changed, 41 insertions(+), 39 deletions(-)
 create mode 100644 include/bits/strings_fortified.h
 copy sysdeps/arm/tst-armtlsdesclocmod.c => string/bits/strings_fortified.h

You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]