This is the mail archive of the
mailing list for the GDB project.
Re: patchwork.sourceware.org is live!
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, gdb at sourceware dot org, carlos at redhat dot com, fche at redhat dot com, gbenson at redhat dot com
- Date: Mon, 26 May 2014 13:22:37 +0530
- Subject: Re: patchwork.sourceware.org is live!
- Authentication-results: sourceware.org; auth=none
- References: <20140523211338 dot GK12497 at spoyarek dot pnq dot redhat dot com> <5382E7F2 dot 4020506 at suse dot com> <CAAHN_R0zVp8B7zXfARzvKvETx9kLZp1FYPN9pUWDwV4cNCjCvA at mail dot gmail dot com> <5382EF22 dot 4060705 at suse dot com>
On 26 May 2014 13:07, Andreas Jaeger <firstname.lastname@example.org> wrote:
> What happens if one person says "fine" while another one disagrees? Is
> Accepted then the right state for this?
The first reviewer sets 'Accepted' (assuming she doesn't need another
reviewer to validate) and if another reviewer disagrees then he can
set the status back to 'Under Review'. if he agrees, then there's no
need to change any status.
> Could you write up a workflow: Live of a patch, something like:
> 1. Patch gets submitted, system puts patch into state NEW
> 2. Reviewer comments on it:
> a) Disagrees: Sets it to
> b) agrees: Sets it to
> c) Not a patch for glibc, set it to Not Applicable
> 3. Patch gets committed: Set it to Commited/Accepted
That's a good idea. I have modified the current document and also
added the Committed status to the document. Once we have consensus on
adding the new 'Committed' status, I'll also add it to patchwork.