This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: Your bfd changes broke sh sim
- From: Danny Backx <danny dot backx at scarlet dot be>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: dannybackx at users dot sourceforge dot net, binutils at sourceware dot org, gdb at sourceware dot org
- Date: Sat, 19 Jul 2008 07:52:27 +0200
- Subject: Re: Your bfd changes broke sh sim
- References: <200807190352.m6J3qdr0011498@ignucius.se.axis.com>
- Reply-to: danny dot backx at scarlet dot be
On Sat, 2008-07-19 at 05:52 +0200, Hans-Peter Nilsson wrote:
> > From: Danny Backx <danny.backx@scarlet.be>
> > Date: Fri, 18 Jul 2008 20:12:39 +0200
>
> > I've tested (and tested again) with
> > ./configure --enable-targets=all
>
> Looks like you didn't even try and build binutils *without*
> --enable-targets=all, because you broke e.g. sh-elf (and yes,
> sh-pe too). For --target=sh-elf, make all:
I was told to check --enable-targets=all in addition to what I was doing
(several arm targets). I did that.
Here's what I just found (unless I overlooked something) :
- I argued with Nick about where this code needed to be, the initial
place was peXXigen.c but I argued that this appeared to be the wrong
place because it could get generated more than once.
- Then I was given a choice where to put it, evidently I made the wrong
choice (pe-arm-wince.c).
- I just moved it back and tested with three builds :
configure --enable-targets=all
configure --target=arm-wince
configure --target=sh-elf
and found that only the last one failed to build, even with the code
in peXXigen.c.
- Inspection reveals that peXXigen.c isn't compiled for sh-elf, so this
was the wrong choice too.
I see three options :
- remove the line that causes this in coff-sh.c and change it as in all
the other architectures. Then all this only works for ARM, not for ARM
and SH as it is supposed to.
- remove all the smart configuration stuff that Nick talked me into and
revert all this to a dumb ARM-only patch
- find a better place to store the code
Please advise.
Danny
> I suggest you revert your change and move
> pe_print_ce_compressed_pdata out of pe-arm-wince.c (clearly the
> wrong place) and into peXXigen.c or its own file (don't forget
> to adjust the build machinery), making it the default of a
> target-dependent hook, overridden for pe-mips or something.
>
> brgds, H-P
>
--
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info