This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: gdb testsuite Makefile.in issue
- From: Daniel Jacobowitz <drow at false dot org>
- To: Michael Snyder <Michael dot Snyder at palmsource dot com>
- Cc: gdb at sourceware dot org
- Date: Wed, 28 Feb 2007 19:00:27 -0500
- Subject: Re: gdb testsuite Makefile.in issue
- References: <1172705549.9783.5.camel@localhost.localdomain>
On Wed, Feb 28, 2007 at 03:32:29PM -0800, Michael Snyder wrote:
> Folks,
>
> The following line has frequently caused me problems:
>
> t='$(program_transform_name)'; echo runtest | sed -e '' $$t; \
>
> I think you do not run into it if you have dejagnu in your
> source tree, or if your host == target. But if those conditions
> are not met, this line bombs.
>
> My shell script foo is not strong, but I believe it should be
> "sed -e '$$t';", not "sed -e '' $$t'"
>
> Yes? No?
Why should it be any of those? It's just runtest, not
$target-runtest. The line gets overridden anyway if you run make
check up a directory, I imagine that's why I never see it.
Anyway, gcc uses:
AR_FOR_TARGET := $(shell \
if [ -f $(objdir)/../binutils/ar ] ; then \
echo $(objdir)/../binutils/ar ; \
else \
if [ "$(host)" = "$(target)" ] ; then \
echo $(AR); \
else \
t='$(program_transform_name)'; echo ar | sed -e $$t ; \
fi; \
fi)
So I would imagine that removing the '' is all it takes. Or maybe
those are wrong too, I don't think they get used much.
--
Daniel Jacobowitz
CodeSourcery