This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix printf of a convenience variable holding an inferior address
On Wednesday, March 04 2020, Joel Brobecker wrote:
> Hi Sergio,
>
>> >>> gdb/ChangeLog:
>> >>> 2020-03-02 Sergio Durigan Junior <sergiodj@redhat.com>
>> >>>
>> >>> * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
>> >>> when verifying if dealing with a convenience variable.
>> >>>
>> >>> gdb/testsuite/ChangeLog:
>> >>> 2020-03-02 Sergio Durigan Junior <sergiodj@redhat.com>
>> >>>
>> >>> * gdb.base/printcmds.exp: Add test to verify printf of a
>> >>> variable holding an address.
>> >>
>> >> LGTM.
>> >
>> > Thanks, pushed:
>> >
>> > 7b973adce2b486518d3150db257b179e1b9a5d33
>>
>> BTW, this also affects 9.1 (in fact, that's where I found the bug). I
>> can create a tracking bug and backport it to the branch if the issue and
>> fix are deemed important enough.
>
> Do you know if this issue is a regression, compared to previous
> released versions?
Hey Joel,
Yeah, this is a regression. GDB 8.3 worked fine.
> In terms of putting it in 9.2, I think we could do it; the patch
> does look safe to me.
Cool. So, is the process the same (now that we're using a different
versioning scheme)? Do I just open a bug again 9.1 and push the
backported patch to the branch?
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/