Re: [PATCH][gdb] Remove trailing "done" after "Reading symbols from" message

[Andrew Burgess <andrew dot burgess at embecosm dot com>]

* Tom de Vries <tdevries@suse.de> [2020-03-04 15:13:08 +0100]:

> On 04-03-2020 15:07, Andrew Burgess wrote:
> > * Tom de Vries <tdevries@suse.de> [2020-03-04 14:21:34 +0100]:
> > 
> >> Hi,
> >>
> >> Using verbose, we get some detail on symbol loading:
> >> ...
> >> $ gdb a.out -iex "set verbose on"
> >> Reading symbols from a.out...
> >> Reading in symbols for /home/vries/hello.c...done.
> >> (gdb)
> >> ...
> >>
> >> And using debug symtab-create, much more detail:
> >> ...
> >> $ gdb a.out -iex "set verbose on" -iex "set debug symtab-create 1"
> >> Reading symbols from a.out...
> >> Reading minimal symbols of objfile /data/gdb_versions/devel/lto/a.out ...
> >> Installing 30 minimal symbols of objfile /data/gdb_versions/devel/lto/a.out.
> >> Done reading minimal symbols.
> >> Creating one or more psymtabs for objfile /data/gdb_versions/devel/lto/a.out ...
> >> Created psymtab 0x35a3de0 for module ../sysdeps/x86_64/start.S.
> >> Created psymtab 0x353e4e0 for module init.c.
> >> Created psymtab 0x353e560 for module ../sysdeps/x86_64/crti.S.
> >> Created psymtab 0x353e5e0 for module /home/vries/hello.c.
> >> Created psymtab 0x35bd530 for module elf-init.c.
> >> Created psymtab 0x35bd5b0 for module ../sysdeps/x86_64/crtn.S.
> >> Reading in symbols for /home/vries/hello.c...Created compunit symtab 0x354bd20 for hello.c.
> >> done.
> >> (gdb)
> > 
> > I'm struggling to understand what problem you're trying to solve
> > here.  In general, if we switch on any of the 'set debug ...' flags
> > the output from GDB gets confused.  These flags aren't intended for
> > general use, and trying to "fix" GDB's output in the face of these
> > flags is going to be a huge task, for I'm not sure what benefit.
> > 
> > Other than the output looking a little neater, is there an actual
> > problem solved here?
> 
> This patch is intended to make the output look a little neater.

Oh, yeah, sorry, I miss-read the original patch description.  I'm fine
with this.

Thanks,
Andrew