This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[pushed] Make "gnutarget" const
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Wed, 4 Mar 2020 16:28:00 -0700
- Subject: [pushed] Make "gnutarget" const
I noticed that gnutarget was not "const". Since writing through this
pointer would probably be a bug, I think it ought to be. This patch
makes the change.
gdb/ChangeLog
2020-03-04 Tom Tromey <tom@tromey.com>
* jit.c (bfd_open_from_target_memory): Make "target" const.
* corefile.c (gnutarget): Now const.
* gdbcore.h (gnutarget): Now const.
---
gdb/ChangeLog | 6 ++++++
gdb/corefile.c | 2 +-
gdb/gdbcore.h | 2 +-
gdb/jit.c | 3 ++-
4 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/gdb/corefile.c b/gdb/corefile.c
index 3b9f8c76052..4ce1bb78f28 100644
--- a/gdb/corefile.c
+++ b/gdb/corefile.c
@@ -415,7 +415,7 @@ write_memory_signed_integer (CORE_ADDR addr, int len,
/* The current default bfd target. Points to storage allocated for
gnutarget_string. */
-char *gnutarget;
+const char *gnutarget;
/* Same thing, except it is "auto" not NULL for the default case. */
static char *gnutarget_string;
diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h
index 9d0f62bc980..7fef4d809ea 100644
--- a/gdb/gdbcore.h
+++ b/gdb/gdbcore.h
@@ -164,7 +164,7 @@ extern void validate_exec_file (int from_tty);
/* The current default bfd target. */
-extern char *gnutarget;
+extern const char *gnutarget;
extern void set_gnutarget (const char *);
diff --git a/gdb/jit.c b/gdb/jit.c
index eeaab70bfe0..35b7167270d 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -136,7 +136,8 @@ mem_bfd_iovec_stat (struct bfd *abfd, void *stream, struct stat *sb)
/* Open a BFD from the target's memory. */
static gdb_bfd_ref_ptr
-bfd_open_from_target_memory (CORE_ADDR addr, ULONGEST size, char *target)
+bfd_open_from_target_memory (CORE_ADDR addr, ULONGEST size,
+ const char *target)
{
struct target_buffer *buffer = XNEW (struct target_buffer);
--
2.17.2