Re: [PATCHv3 1/2] gdbserver: Add mechanism to prevent sending T stop packets

[Pedro Alves <palves at redhat dot com>]

On 3/2/20 11:54 AM, Andrew Burgess wrote:
> There is a developer only feature in gdbserver that provides a
> command line option --disable-packet that prevents some packets from
> being sent, which is used to increase test coverage within GDB.
> 
> This commit extends this mechanism to prevent GDBserver from sending
> the T stop reply packets, instead limiting GDBserver to only send the
> S stop reply packets.
> 
> The S stop reply packet is part of the older target control mechanism,
> which has design flaws that were worked around with the introduction
> of the newer target control mechanism, which uses the T stop reply
> packet.
> 
> Limiting GDBserver to use S stop packets instead of T stop packets
> will, inevitably, mean that GDBserver doesn't function correctly in
> many cases involving multiple threads, however, I don't think this is
> too important, this is a developer only feature, intended to allow us
> to test GDB.
> 
> A new test that makes use of this feature will be added in the next
> commit.
> 
> gdbserver/ChangeLog:
> 
> 	* remote-utils.cc (prepare_resume_reply): Add ability to convert T
> 	reply into an S reply.
> 	* server.cc (disable_packet_T): New global.
> 	(captured_main): Set new global when appropriate.
> 	* server.h (disable_packet_T): Declare.

OK.

Thanks,
Pedro Alves