This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Small clean up of use_displaced_stepping
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 29 Feb 2020 19:41:24 -0700
- Subject: Re: [PATCH] Small clean up of use_displaced_stepping
- References: <20200227224424.270604-1-simon.marchi@polymtl.ca>
On Thu, 27 Feb 2020 17:44:24 -0500
Simon Marchi <simon.marchi@polymtl.ca> wrote:
> This function returns the result of a quite big condition. I think it
> would be more redeable if it was broken up in smaller pieces and
s/redeable/readable/
> commented. This is what this patch does.
>
> I also introduced gdbarch_supports_displaced_stepping, since it shows
> the intent better than checking for gdbarch_displaced_step_copy_insn_p.
> I also used that new function in displaced_step_prepare_throw.
>
> I also updated the comment on top of can_use_displaced_stepping, which
> seemed a bit outdated with respect to non-stop. The comment likely
> dates from before it was possible to have targets that always operate
> non-stop under the hood, even when the user-visible mode is all-stop.
>
> No functional changes intended.
>
> gdb/ChangeLog:
>
> * infrun.c (gdbarch_supports_displaced_stepping): New.
> (use_displaced_stepping): Break up conditions in smaller pieces.
> Use gdbarch_supports_displaced_stepping.
> (displaced_step_prepare_throw): Use
> gdbarch_supports_displaced_stepping.
I read through the patch. It appears to be equivalent to the terse
conditional that used to be there. I find it much easier to understand
now. Thanks for doing this.
Kevin