This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Regression] [PATCH] Do not print empty-group regs when printing general ones
- From: Shahab Vahedi <shahab dot vahedi at gmail dot com>
- To: Luis Machado <luis dot machado at linaro dot org>
- Cc: Christian Biesinger <cbiesinger at google dot com>, Shahab Vahedi <Shahab dot Vahedi at synopsys dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>, Francois Bedard <Francois dot Bedard at synopsys dot com>, Andrew Burgess <andrew dot burgess at embecosm dot com>
- Date: Fri, 28 Feb 2020 14:36:18 +0100
- Subject: Re: [Regression] [PATCH] Do not print empty-group regs when printing general ones
- References: <20200120155315.30333-1-shahab.vahedi@gmail.com> <CH2PR12MB3847E492663E7997CFAB1741A6070@CH2PR12MB3847.namprd12.prod.outlook.com> <75f76108-a233-6fce-66a2-86452371e1be@linaro.org> <CAPTJ0XGEgr5RTMhcUZjrtr5pJXdMdgb-tO=mT_K0NjiO=pgwcw@mail.gmail.com> <9c256b27-4a00-8830-46e2-934922e39cc2@linaro.org>
On Fri, Feb 28, 2020 at 10:31:26AM -0300, Luis Machado wrote:
>
>
> On 2/28/20 10:22 AM, Christian Biesinger wrote:
> > On Fri, Feb 28, 2020 at 7:08 AM Luis Machado <luis.machado@linaro.org> wrote:
> > >
> > > On 1/31/20 7:34 AM, Shahab Vahedi wrote:
> > > > This patch was reviewed once (as OK):
> > > > https://sourceware.org/ml/gdb-patches/2020-01/msg00613.html
> > > >
> > > > Could someone review/merge it?
> > > >
> > > >
> > > > Cheers,
> > > > Shahab
> > > >
> > >
> > > FTR, this has broken general register printing for ARM/AArch64. Now
> > > "info reg" shows nothing.
> > >
> > > Given there are already remote stubs, probes and gdbservers running out
> > > there, this is an undesirable change to have.
> > >
> > > I had an IRC chat with Christian and he pointed me at some documentation
> > > stating empty-group registers should not be printed, but i think this is
> > > a case where the implementation has diverged from the documentation.
> > >
> > > https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Format
> > >
> > > We could probably patch up any non-standard target description XML's
> > > from now on, but the existing behavior may have to be preserved.
> >
> > Most targets under features/ do not specify group="general" in their
> > XML files for anything (only S/390 does); it seems like that should
> > maybe be fixed either way?
>
> I agree.
The documentation [1] says:
If no group is specified, GDB will not display the register in info registers
[1]
https://sourceware.org/gdb/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Format