This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 6/6] Fix comment for 'gdb_dlopen'
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Cc: Pedro Alves <palves at redhat dot com>, Tom Tromey <tom at tromey dot com>, Eli Zaretskii <eliz at gnu dot org>, Ruslan Kabatsayev <b7 dot 10110111 at gmail dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Wed, 26 Feb 2020 15:05:42 -0500
- Subject: [PATCH 6/6] Fix comment for 'gdb_dlopen'
- References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com>
The 'gdb_dlopen' function doesn't return NULL if the shlib load
fails;n it actually throws an error. This patch updates the comment
to reflect this.
gdbsupport/ChangeLog:
yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
* gdb-dlfcn.h (gdb_dlopen): Update comment.
---
gdbsupport/gdb-dlfcn.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdbsupport/gdb-dlfcn.h b/gdbsupport/gdb-dlfcn.h
index 258cfebbc3..9e72a53dc0 100644
--- a/gdbsupport/gdb-dlfcn.h
+++ b/gdbsupport/gdb-dlfcn.h
@@ -32,8 +32,8 @@ struct dlclose_deleter
typedef std::unique_ptr<void, dlclose_deleter> gdb_dlhandle_up;
/* Load the dynamic library file named FILENAME, and return a handle
- for that dynamic library. Return NULL if the loading fails for any
- reason. */
+ for that dynamic library. Throw an error if the loading fails for
+ any reason. */
gdb_dlhandle_up gdb_dlopen (const char *filename);
--
2.24.1