This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5] Add debuginfod support to GDB
- From: Tom Tromey <tom at tromey dot com>
- To: Aaron Merey <amerey at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Simon Marchi <simark at simark dot ca>, Tom Tromey <tom at tromey dot com>
- Date: Tue, 25 Feb 2020 20:53:51 -0700
- Subject: Re: [PATCH v5] Add debuginfod support to GDB
- References: <CAJDtP-S3tXgiXOu+rWs2xeNir14UM7D-C4=0VZ6nKXyRg-EKfA@mail.gmail.com>
>>>>> "Aaron" == Aaron Merey <amerey@redhat.com> writes:
Aaron> gdb/ChangeLog:
Aaron> 2020-02-25 Aaron Merey <amerey@redhat.com>
Aaron> * Makefile.in: Handle optional debuginfod support.
Aaron> * NEWS: Update.
Thank you again.
Aaron> + printf_filtered (_("Download failed: %s. Continuing without source file %ps.\n"),
GNU style is two spaces after a period.
Aaron> + printf_filtered (_("Download failed: %s. Continuing without debug info for %ps.\n"),
Here too.
Aaron> + strerror (-fd.get ()),
safe_strerror. There was another spot that needed this too.
Ok with those nits fixed. You don't have to re-submit it.
Tom