This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 03/14] Introduce dwarf2_per_objfile::obstack

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simark at simark dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 21 Feb 2020 17:44:41 -0700
Subject: Re: [PATCH 03/14] Introduce dwarf2_per_objfile::obstack
References: <20200215165444.32653-1-tom@tromey.com> <20200215165444.32653-4-tom@tromey.com> <b01063a5-3c18-58a3-f163-6161dd3ed53f@simark.ca>

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> +      struct dwarf2_per_objfile *dwarf2_per_objfile
>> +	= get_dwarf2_per_objfile (objfile);
>> +      qfn->real_names = OBSTACK_CALLOC (&dwarf2_per_objfile->obstack,
>> +					qfn->num_file_names, const char *);
>> +    }

Simon> The callers of dw2_get_real_path should be able to pass the dwarf2_per_objfile directly,
Simon> instead of the objfile, simplifying this.

Indeed.  I made this change.

Tom

References:
- [PATCH 00/14] Share DWARF partial symtabs between objfiles
  - From: Tom Tromey
- [PATCH 03/14] Introduce dwarf2_per_objfile::obstack
  - From: Tom Tromey
- Re: [PATCH 03/14] Introduce dwarf2_per_objfile::obstack
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]