This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Check for null result from gdb_demangle
- From: Tom Tromey <tom at tromey dot com>
- To: "Ali Tamur via gdb-patches" <gdb-patches at sourceware dot org>
- Cc: Ali Tamur <tamur at google dot com>, kmoy at google dot com
- Date: Fri, 21 Feb 2020 08:19:45 -0700
- Subject: Re: [PATCH] Check for null result from gdb_demangle
- References: <20200213063140.129700-1-tamur@google.com>
>>>>> "Ali" == Ali Tamur via gdb-patches <gdb-patches@sourceware.org> writes:
Ali> I am sending this patch on behalf of kmoy@google.com, who discovered the bug
Ali> and wrote the fix.
Ali> gdb_demangle can return null for strings that don't properly demangle. The null
Ali> check was mistakenly removed in commit 43816ebc335. Without this check, GDB
Ali> aborts when loading symbols from some binaries.
Ali> gdb/ChangeLog:
Ali> * dwarf2/read.c (dwarf2_name): Add null check.
I'm pushing this now. It came up a second time so I think it ought to
go in.
Tom