This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make '{putchar,fputc}_unfiltered' use 'fputs_unfiltered'
Hi Sergio and Tom,
On Thu, Feb 20, 2020 at 04:04:05PM -0500, Sergio Durigan Junior wrote:
> On Thursday, February 20 2020, Tom Tromey wrote:
>
> >>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
> >
> > Sergio> gdb/ChangeLog:
> > Sergio> 2020-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
> > Sergio> Tom Tromey <tom@tromey.com>
> > Sergio> * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
> > Sergio> of 'fputc_unfiltered'.
> > Sergio> (putchar_unfiltered): Call 'fputc_unfiltered'.
> > Sergio> (fputc_unfiltered): Call 'fputs_unfiltered'.
> >
> > Looks good to me. Thanks for doing this.
>
> Thanks, pushed.
>
> 3f702acd7d562d3a33c59d6398ae74058438d2c7
I think the commit that Sergio incriminated is also in gdb-9-branch.
Do you confirm?
If yes, what about creating a GDB PR, and backporting this change
to the gdb-9-branch (all changes after the .1 must have a PR)?
The change looks relatively safe to me, but maybe it's not as simple
as we might think, especially since this section of the code _is_ quite
central...
Thank you!
--
Joel