This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Add debuginfod support to GDB


On 2020-02-20 1:02 p.m., Simon Marchi wrote:
> I think we still need something just after the debuginfod_find_debuginfo
> and debuginfod_find_source calls to throw the "quit" exception, if the quit
> flag is set at this point.  Without that, the debuginfod_source_query and
> debuginfod_debuginfo_query will return a failure.  The calling code could
> therefore conclude that debug info is not available (and cache that value
> somehwere), for a file for which debug info is actually available.  When
> the execution reaches the event loop and we process the quit flag, it
> would be too late, the damage will have been done.

Following a discussion on IRC, I changed my mind, the simplest solution
for now would be: when the user cancels a download, GDB will continue
as if debug info was not available for that objfile.  However, I would suggest
printing a message saying that the download of debug info for XYZ was cancelled,
so the user is not surprised to not have its debug info.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]