This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simark at simark dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 20 Feb 2020 09:49:57 -0700
Subject: Re: [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit
References: <20200215165444.32653-1-tom@tromey.com> <20200215165444.32653-2-tom@tromey.com> <01167589-fae4-39a0-1ebe-0c7d4cbf52b5@simark.ca> <87o8tu3c1g.fsf@tromey.com> <87o8tu86ci.fsf@tromey.com> <3a3f1f39-c715-58ba-06a8-2980afb82c53@simark.ca>

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> Thanks, that LGTM.  If you want to use std::binary_search, that would be fine
Simon> as well.

I tried this but it wasn't notably simpler and it meant changes to the
error handling, so I dropped it.

Tom

References:
- [PATCH 00/14] Share DWARF partial symtabs between objfiles
  - From: Tom Tromey
- [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit
  - From: Tom Tromey
- Re: [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit
  - From: Simon Marchi
- Re: [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit
  - From: Tom Tromey
- Re: [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit
  - From: Tom Tromey
- Re: [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]