This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [pushed] Remove useless NULL check in python.c

From: Tom Tromey <tom at tromey dot com>
To: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
Cc: Tom Tromey <tromey at adacore dot com>, Christian Biesinger <cbiesinger at google dot com>
Date: Wed, 19 Feb 2020 08:34:59 -0700
Subject: Re: [pushed] Remove useless NULL check in python.c
References: <20200219145728.14136-1-tromey@adacore.com> <CAPTJ0XHinQErb9_gbKM-sTqhvkQ_-6WNTdavtbfKqCD4SX1zMw@mail.gmail.com>

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> Have you considered using STD::wstring instead of this manual memory
Christian> management?

I did, but converting to wstring seemed unusually complicated compared
to what we have.  Though, this isn't a part of C++ that I know well, so
I'm open to being wrong about that.

Tom

References:
- [pushed] Remove useless NULL check in python.c
  - From: Tom Tromey
- Re: [pushed] Remove useless NULL check in python.c
  - From: Christian Biesinger via gdb-patches

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]