This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/14] gdb/testsuite: Fix an invalid is_remote check in fileio test
- From: Shahab Vahedi <Shahab dot Vahedi at synopsys dot com>
- To: Luis Machado <luis dot machado at linaro dot org>, Shahab Vahedi <shahab dot vahedi at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: Francois Bedard <Francois dot Bedard at synopsys dot com>, Anton Kolesov <Anton dot Kolesov at synopsys dot com>
- Date: Tue, 18 Feb 2020 07:31:04 +0000
- Subject: Re: [PATCH 01/14] gdb/testsuite: Fix an invalid is_remote check in fileio test
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wLKaUK7DPLlTLQD7x5LxlHSS8DONEInZPexuKKkci4Q=; b=DiR4U2GuzcZfz/ol31EaCYvJTVAgOthMru525rGcPLaLA964Abp/GSxhuUH2VWxVbD4mfDUwNMA90CGLYvZcLcF4mGRlbiq/HnLV2crHMdNVuvtd1Z12GeWJR7mQgMGk1ZqFR89juzA3aHxLx6pJEa8gJkU6RA1VZp6mI0mapHIA16/YuuHDXaDPDJ4EDF6PsOTjOwUJG4p8nK/j7Qy6fQUWc6kQYGPM6kaDXAmSeA+v27RPrDZGDcy8jrEEGiTY/iLjVYcDBod3u+IIYcqN1IRwD0YQfwiFrtMGzo64+ES8RoZzewFLe4TaubJPVrVtRZNTORoJIJlDKD4Ttrpyuw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pja18HJHUpoLy2Cgzud6zDK591A60TbZkXUgUwINdJO3US5dNKIkiTyF4Xo05kY1JDk9vSXcUbe00RBle+jssd5tLPlUUmZgX8VZPQt8oagyXPEGlsC4B9ReR/tSQEB3icafHAZrfUxHN0euLcgEoubPgA/8ds4FntJyYbjIhrV/oe25x+QbvCrhrBaY4GBmQGbcR298ekDiecW9JjP3CLRPzV1bLZUGvLbPpAmZzwPtdFhlnYdVEC6Bs1fw8qeAnO6uPu8Z6y/9JgtvmhBeZoQ0+ANoQdh6pc61hFIRqVgka/F6VMF4RqUFfQOQlsMdPfSADt75tDIKf0qDh79eKg==
- References: <20200207150003.8383-1-shahab.vahedi@gmail.com> <20200207150003.8383-2-shahab.vahedi@gmail.com> <e508a214-02fe-a71b-82c8-1b83cdcde607@linaro.org>
On 2/11/20 8:29 AM, Luis Machado wrote:
> Hi,
>
> On 2/7/20 11:59 AM, Shahab Vahedi wrote:
>> From: Anton Kolesov <Anton.Kolesov@synopsys.com>
>>
>> Fileio test improperly checks if [is_remote host] and if it is, then
>> uses file path that is safe to use on remote host. But the problem is
>> that [is_remote host] returns state of *this* host, not of the remote
>> target, where filepaths actually matter. This patch fixes that.
>
> Do you remember what that error was? I don't see any errors running on my end. Though the patch doesn't introduce new errors as well.
>
> Were you using a different board file that exercised gdbserver running on a remote host?
Indeed specific boards for ARC are used. And yes, there were/are 2 ways
that these boards were executed: through a simulator and on real boards
(remote hosts).
>
> I'm trying to understand what the problem is.
>
>>
>> gdb/testsuite/ChangeLog:
>> 2016-12-16 Anton Kolesov <Anton.Kolesov@synopsys.com>
>>
>> * gdb.base/fileio.exp: Use "target" instead of "host".
>>
>> Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
>> ---
>> gdb/testsuite/gdb.base/fileio.exp | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp
>> index 9735869e5190..627a685e118d 100644
>> --- a/gdb/testsuite/gdb.base/fileio.exp
>> +++ b/gdb/testsuite/gdb.base/fileio.exp
>> @@ -23,7 +23,7 @@ if [target_info exists gdb,nofileio] {
>> standard_testfile
>> -if {[is_remote host]} {
>> +if {[is_remote target]} {
>> set outdir .
>> } else {
>> set outdir [standard_output_file {}]
>>