This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] rust/25535 Apply embedded offset to enum variant calculation
On 2020-02-12 2:54 a.m., Tom Tromey wrote:
>>> gdb/ChangeLog
>>> PR rust/25535
>>> * rust-lang.c (rust_print_enum): Apply embedded_offset to
>>> rust_enum_variant calculation.
>>>
>>> gdb/testsuite/ChangeLog
>>> PR rust/25535
>>> * gdb.rust/simple.exp: Add test.
>>> * gdb.rust/simple.rs: Add test.
>
> Simon> Hi Doug,
>
> Simon> Tom has this big series that gets rid of the val_print API (and therefore embedded_offset),
> Simon> which I think was on its way in. See this patch here in particular:
>
> Simon> https://sourceware.org/ml/gdb-patches/2019-12/msg00288.html
>
> Simon> Could you check if that fixes the bug? Of course, the test you add would still be relevant.
>
> I think it's fine to land this now.
>
> I'll try to rebase the val_print thing soon. I've kind of been breaking
> things a lot so I've been putting it off a little.
Agreed, we don't lose anything by merging this now.
Simon